qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR


From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR
Date: Tue, 15 Mar 2016 09:05:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0

On 03/14/2016 09:26 PM, Thomas Huth wrote:
>> > @@ -8093,7 +8137,7 @@ static void init_proc_book3s_64(CPUPPCState *env, 
>> > int version)
>> >      case BOOK3S_CPU_POWER7:
>> >      case BOOK3S_CPU_POWER8:
>> >          gen_spr_book3s_ids(env);
>> > -        gen_spr_amr(env);
>> > +        gen_spr_amr(env, version >= BOOK3S_CPU_POWER8);
>> >          gen_spr_book3s_purr(env);
>> >          env->ci_large_pages = true;
>> >          break;
> I think this last hunk (and thus the "has_iamr" parameter of that
> function) rather belong to the next patch, since it is not used here yet.

Yes. I fixed a compile break but I moved the hunk in the wrong patch.

Thanks,

C. 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]