[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with parti
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores |
Date: |
Wed, 2 Dec 2015 08:34:20 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Dec 01, 2015 at 11:37:03AM +1100, David Gibson wrote:
> On Fri, Nov 20, 2015 at 06:24:30PM +0530, Bharata B Rao wrote:
> > Prevent guests from booting with CPU topologies that have partially
> > filled CPU cores or can result in partially filled CPU cores after
> > CPU hotplug like
> >
> > -smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or
> > -smp 15,sockets=1,cores=4,threads=4,maxcpus=17.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
>
> Reviewed-by: David Gibson <address@hidden>
>
> I may have missed a bit of the discussion leading up to this. What
> was the rationale for still allowing partially filled sockets (and
> otherwise doing things at core rather than socket level?)
This is generic parsing code. I don't remember an explicit discussion
around allowing or dis-allowing paritialy filled sockets. I thought
disallowing partially filled cores from generic smp parsing code would
be an acceptable first step for all archs.
Regards,
Bharata.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores,
Bharata B Rao <=