[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_r
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init |
|
Date: |
Thu, 01 Oct 2015 09:39:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 30/09/2015 10:30, Thomas Huth wrote:
>>> > @@ -944,7 +944,7 @@ static void tcx_initfn(Object *obj)
>>> > SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>>> > TCXState *s = TCX(obj);
>>> >
>>> > - memory_region_init_ram(&s->rom, NULL, "tcx.prom", FCODE_MAX_ROM_SIZE,
>>> > + memory_region_init_ram(&s->rom, OBJECT(s), "tcx.prom",
>>> > FCODE_MAX_ROM_SIZE,
>>> > &error_fatal);
>> Why "OBJECT(s)" and not simply "obj" ?
>
> No particular reason, just the way my brain worked. :)
I can touch it up on commit.
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init, Markus Armbruster, 2015/10/08
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init, Mark Cave-Ayland, 2015/10/08
[Qemu-ppc] [PATCH 3/3] macio: move DBDMA_init from instance_init to realize, Paolo Bonzini, 2015/10/05