[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 05/36] spapr: Make ibm, change-msi respect 3 return val
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 05/36] spapr: Make ibm, change-msi respect 3 return values |
Date: |
Wed, 23 Sep 2015 11:55:07 +1000 |
From: Sam Bobroff <address@hidden>
Currently, rtas_ibm_change_msi() always returns four values even if
less are specified.
Correct this by only returning the fourth parameter if it was
requested.
This is specified by PAPR.
Signed-off-by: Sam Bobroff <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index a2feb4c..6782fd0 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -375,7 +375,9 @@ out:
rtas_st(rets, 0, RTAS_OUT_SUCCESS);
rtas_st(rets, 1, req_num);
rtas_st(rets, 2, ++seq_num);
- rtas_st(rets, 3, ret_intr_type);
+ if (nret > 3) {
+ rtas_st(rets, 3, ret_intr_type);
+ }
trace_spapr_pci_rtas_ibm_change_msi(config_addr, func, req_num, irq);
}
--
2.4.3
- [Qemu-ppc] [PULL 00/36] spapr-next queue 20150923, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 01/36] spapr: Provide an error message when migration fails due to htab_shift mismatch, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 03/36] spapr: Add /ibm,partition-name, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 18/36] spapr: Initialize hotplug memory address space, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 12/36] pseries: define coldplugged devices as "configured", David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 09/36] ppc/spapr: Use qemu_log_mask() for hcall_dprintf(), David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 02/36] spapr: Create pseries-2.5 machine, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 11/36] sPAPR: Introduce rtas_ldq(), David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 04/36] spapr: Add /rtas/ibm,change-msix-capable, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 05/36] spapr: Make ibm, change-msi respect 3 return values,
David Gibson <=
- [Qemu-ppc] [PULL 06/36] spapr: SPLPAR Characteristics, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 24/36] spapr: Make hash table size a factor of maxram_size, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 20/36] spapr: Don't use QOM [*] syntax for DR connectors., David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 08/36] spapr_drc: Fix potential undefined behaviour, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 27/36] spapr: Provide better error message when slots exceed max allowed, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 21/36] spapr: Use QEMU limit for maximum CPUs number, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 26/36] spapr: Don't allow memory hotplug to memory less nodes, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 35/36] sPAPR: Revert don't enable EEH on emulated PCI devices, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 19/36] spapr_drc: use RTAS return codes for methods called by RTAS, David Gibson, 2015/09/22
- [Qemu-ppc] [PULL 10/36] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add, David Gibson, 2015/09/22