[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sP
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector |
Date: |
Tue, 15 Sep 2015 13:05:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 15/09/2015 02:30, David Gibson wrote:
>>> I think the comment is wrong or at least inaccurate; it only
>>> applies to the external QOM interface. The patch is a good
>>> idea, even though OBJECT(x)->y traditionally is not used
>>> (instead you assign OBJECT(x) to a different Object*
>>> variable).
> Ok.. so are you prepared to give a Reviewed-by, or do I need to
> ask someone else (Andreas?) to approve this as QOMishly correct?
I am, but as I said in another message I wonder if accessing the
parent field is actually necessary.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJV9/toAAoJEL/70l94x66DlgIH/3gVH53/bBLzUc77IfDbGlMZ
FIA94/uVb+HJWz29y0yv3V9RO+PpjhO9rQWUM3K+1TyH+Bu0st9HlGcxjhZVXpsH
So0IcVgBGFZry+3XyuIZ9TanpDcKo1cXSc5OZ/P7eBP/TviLcKshtfmn9WpgRWm7
DnVBFe1rSId7a8qn8BUeHyHtCLEwWcn8sOJla4w66PiGXVBG1p+mMU+lOXm6mQMD
sy3LNMRS2duhDyMncMF6tsTn03CesfiW+2b1U5U/Q3ZIFTLdOLFMTiBK8giTfd2J
FoePn1sZkF5SW4fPL8Gye1qbmnkpLUDMODHTUF3AI61Q11CAULFjxOkPK/QGEEI=
=lh5f
-----END PGP SIGNATURE-----
- Re: [Qemu-ppc] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors., (continued)
- [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, David Gibson, 2015/09/13
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, Bharata B Rao, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, Alexey Kardashevskiy, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, David Gibson, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, Paolo Bonzini, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, Alexey Kardashevskiy, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, Paolo Bonzini, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, David Gibson, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector, David Gibson, 2015/09/14
- Re: [Qemu-ppc] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector,
Paolo Bonzini <=