[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [FIX PATCH] spapr_drc: Return correct state for logical DR in
From: |
Bharata B Rao |
Subject: |
[Qemu-ppc] [FIX PATCH] spapr_drc: Return correct state for logical DR in entity_sense() |
Date: |
Mon, 7 Sep 2015 11:37:04 +0530 |
When drmgr is run in the guest to add a device for which device_add
hasn't been issued in QEMU, configure-connector call fails.
When configure-connector call fails, the guest would release (*)
the previously acquired DRC by setting back the DRC isolation state
to ISOLATED and allocation state to UNUSABLE. These calls will be issued
only if get-sensor-state call returns PRESENT state. However currently for
a logical DR, entity_sense() would unconditinally return UNUSABLE
state only. This prevents any subsequent hotplug of the device with
that DRC.
Fix this by returning the right state in entity_sense() by checking
the allocation_state of DRC.
(*) https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-September/133430.html
Signed-off-by: Bharata B Rao <address@hidden>
Cc: Michael Roth <address@hidden>
---
hw/ppc/spapr_drc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 9ce844a..2586065 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -186,7 +186,11 @@ static sPAPRDREntitySense entity_sense(sPAPRDRConnector
*drc)
*/
state = SPAPR_DR_ENTITY_SENSE_EMPTY;
} else {
- state = SPAPR_DR_ENTITY_SENSE_UNUSABLE;
+ if (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_UNUSABLE) {
+ state = SPAPR_DR_ENTITY_SENSE_UNUSABLE;
+ } else {
+ state = SPAPR_DR_ENTITY_SENSE_PRESENT;
+ }
}
}
--
2.1.0
- [Qemu-ppc] [FIX PATCH] spapr_drc: Return correct state for logical DR in entity_sense(),
Bharata B Rao <=