[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "confi
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured" |
Date: |
Tue, 1 Sep 2015 15:00:25 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote:
> When a device is hotplugged, attach() sets "configured" to
> false, waiting an action from the OS to configure it and then
> to call ibm,configure-connector. On ibm,configure-connector,
> the hypervisor sets "configured" to true.
>
> In case of coldplugged device, attach() sets "configured" to
> false, but firmware and OS never call the ibm,configure-connector
> in this case, so it remains set to false.
>
> It could be harmless, but when we unplug a device, hypervisor
> waits the device becomes configured because for it, a not configured
> device is a device being configured, so it waits the end of configuration
> to unplug it... and it never happens, so it is never unplugged.
>
> This patch set by default coldplugged device to "configured=true",
> hotplugged device to "configured=false".
>
> Signed-off-by: Laurent Vivier <address@hidden>
Merged to spapr-next, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpCjsRlVM5UG.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured",
David Gibson <=