[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [RFC PATCH v4 04/11] cpus: Add a sync version of cpu_remove()
From: |
Bharata B Rao |
Subject: |
[Qemu-ppc] [RFC PATCH v4 04/11] cpus: Add a sync version of cpu_remove() |
Date: |
Thu, 6 Aug 2015 10:57:10 +0530 |
This sync API will be used by the CPU hotplug code to wait for the CPU to
completely get removed before flagging the failure to the device_add
command.
Sync version of this call is needed to correctly recover from CPU
realization failures when ->plug() handler fails.
Signed-off-by: Bharata B Rao <address@hidden>
---
cpus.c | 14 ++++++++++++++
include/qom/cpu.h | 8 ++++++++
2 files changed, 22 insertions(+)
diff --git a/cpus.c b/cpus.c
index 73ae2e7..9d9644e 100644
--- a/cpus.c
+++ b/cpus.c
@@ -999,6 +999,8 @@ static void *qemu_kvm_cpu_thread_fn(void *arg)
qemu_kvm_wait_io_event(cpu);
if (cpu->exit && !cpu_can_run(cpu)) {
qemu_kvm_destroy_vcpu(cpu);
+ cpu->created = false;
+ qemu_cond_signal(&qemu_cpu_cond);
qemu_mutex_unlock(&qemu_global_mutex);
return NULL;
}
@@ -1104,6 +1106,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
}
if (remove_cpu) {
qemu_tcg_destroy_vcpu(remove_cpu);
+ cpu->created = false;
+ qemu_cond_signal(&qemu_cpu_cond);
remove_cpu = NULL;
}
}
@@ -1283,6 +1287,16 @@ void cpu_remove(CPUState *cpu)
qemu_cpu_kick(cpu);
}
+void cpu_remove_sync(CPUState *cpu)
+{
+ cpu->stop = true;
+ cpu->exit = true;
+ qemu_cpu_kick(cpu);
+ while (cpu->created) {
+ qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
+ }
+}
+
/* For temporary buffers for forming a name */
#define VCPU_THREAD_NAME_SIZE 16
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 136d9fe..65c6852 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -655,6 +655,14 @@ void cpu_resume(CPUState *cpu);
*/
void cpu_remove(CPUState *cpu);
+ /**
+ * cpu_remove_sync:
+ * @cpu: The CPU to remove.
+ *
+ * Requests the CPU to be removed and waits till it is removed.
+ */
+void cpu_remove_sync(CPUState *cpu);
+
/**
* qemu_init_vcpu:
* @cpu: The vCPU to initialize.
--
2.1.0
- [Qemu-ppc] [RFC PATCH v4 00/11] sPAPR CPU hotplug, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 11/11] target-ppc: Enable CPU hotplug for POWER8 CPU family, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 02/11] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 06/11] spapr: Create pseries-2.5 machine, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 05/11] xics_kvm: Add cpu_destroy method to XICS, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 07/11] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 03/11] cpus: Reclaim vCPU objects, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 04/11] cpus: Add a sync version of cpu_remove(),
Bharata B Rao <=
- [Qemu-ppc] [RFC PATCH v4 10/11] spapr: CPU hot unplug support, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 09/11] spapr: Support topologies with unfilled cores, Bharata B Rao, 2015/08/06
- [Qemu-ppc] [RFC PATCH v4 08/11] spapr: CPU hotplug support, Bharata B Rao, 2015/08/06
- Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH v4 00/11] sPAPR CPU hotplug, Zhu Guihua, 2015/08/06
- Re: [Qemu-ppc] [RFC PATCH v4 00/11] sPAPR CPU hotplug, David Gibson, 2015/08/11