Re: [Qemu-ppc] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled" state for TCE table

[Alexey Kardashevskiy]

On 05/27/2015 05:05 PM, Paolo Bonzini wrote:
> On 27/05/2015 01:55, Alexey Kardashevskiy wrote:
> > One step back :) Whole dance is what here? There are:
> > 1) del+set_size(0)
> > 2) set_size(not zero)+add
>
> Then no need for begin/commit. :)

I got a new problem here - set_size(0) + set_size(not 0) do not invoke 
region_del/region_add which does not seem right. As the result,
vfio_listener_region_del() never gets called and the IOMMU MR notifier 
stays in the container->giommu_list. What is the correct solution to this?

Incorrect (most likely :) ) solution is in
[PATCH qemu v9 13/13] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows 
(DDW)
where I explicitely do  memory_region_del_subregion() + 
memory_region_add_subregion() which seems to do the right job.

--
Alexey