[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v4 5/8] spapr: Consolidate cpu init code into a ro

From: David Gibson
Subject: Re: [Qemu-ppc] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine
Date: Mon, 15 Jun 2015 16:59:08 +1000
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote:
> Factor out bits of sPAPR specific CPU initialization code into
> a separate routine so that it can be called from CPU hotplug
> path too.
> While at this, use MSR_EP define instead of using 6 directly.

Don't do this please.  MSR[EP] is an obsolete flag from 601.  The
MSR[IP] flag that we're controlling here just happened to re-use the
same bit position, so using the existing MSR_EP define is misleading.

A symbolic name is good, but you should create a new one for MSR[IP]

Or you could just drop this change and do the cleanup of the hardcoded
6 some other time.

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: pgpG72bjcGQwx.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]