[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v4 7/8] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if

From: David Gibson
Subject: Re: [Qemu-ppc] [PATCH v4 7/8] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled
Date: Mon, 15 Jun 2015 16:59:30 +1000
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Jun 05, 2015 at 09:55:57AM +0530, Bharata B Rao wrote:
> When supporting CPU hot removal by parking the vCPU fd and reusing
> it during hotplug again, there can be cases where we try to reenable
> KVM_CAP_IRQ_XICS CAP for the vCPU for which it was already enabled.
> Introduce a boolean member in ICPState to track this and don't
> reenable the CAP if it was already enabled earlier.
> Re-enabling this CAP should ideally work, but currently it results in
> kernel trying to create and associate ICP with this vCPU and that
> fails since there is already an ICP associated with it. Hence this
> patch is needed to work around this problem in the kernel.
> This change allows CPU hot removal to work for sPAPR.
> Signed-off-by: Bharata B Rao <address@hidden>

Reviewed-by: David Gibson <address@hidden>

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: pgpKunoKoFaNk.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]