Re: [Qemu-ppc] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99

[Alexander Graf]

On 21.01.15 17:01, Mark Cave-Ayland wrote:
> Issuing loadvm under -M mac99 would fail for two reasons: firstly an incorrect
> version number for openpic would cause openpic_load() to abort, and secondly
> a cut/paste error when restoring the IVPR and IDR registers caused subsequent
> vmstate sections to become misaligned and abort early.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>

Thanks a lot for all the work you put into this. Do you think you
understand enough to the OpenPIC code by now to be able to convert it to
VMState instead?

That would get rid of the whole class of problems altogether and make
sure we didn't overlook something subtle somewhere else in the code.


Alex