[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where it belongs |
|
Date: |
Wed, 14 Jan 2015 13:40:48 +1100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jan 09, 2015 at 01:59:25PM +0100, Paolo Bonzini wrote:
>
>
> On 09/01/2015 13:53, Alexey Kardashevskiy wrote:
> >> > I think the minimum version should be 2 as well, because migrating from
> >> > version 1 will not set the bypass field correctly.
> > This why the patch is "RFC" :)
> >
> > I can keep the flag in TCETable which would be a bit ugly but won't break
> > migration. Is there any better way to keep compatibility?
>
> No, I don't think so.
Alas, there doesn't seem to be. I have the same thing with my RTC
patches, where I have to keep the rtc_offset field in the
sPAPREnvironment just to grab it on migration from an older version
and stuff it into the new device instead.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpu6xUa7N6aU.pgp
Description: PGP signature