[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 1/2] KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE c
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-ppc] [PATCH v3 1/2] KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE checks |
|
Date: |
Fri, 31 Oct 2014 18:15:36 +0100 |
On Fri, 31 Oct 2014 13:38:18 +0000
Eric Auger <address@hidden> wrote:
> Compute kvm_irqfds_allowed by checking the KVM_CAP_IRQFD extension.
> Remove direct settings in architecture specific files.
>
> Add a new kvm_resamplefds_allowed variable, initialized by
> checking the KVM_CAP_IRQFD_RESAMPLE extension. Add a corresponding
> kvm_resamplefds_enabled() function.
>
> A special notice for s390 where KVM_CAP_IRQFD was not immediatly
> advirtised when irqfd capability was introduced in the kernel.
s/immediatly advirtised/immediately advertised/
> KVM_CAP_IRQ_ROUTING was advertised instead.
>
> This was fixed in "KVM: s390: announce irqfd capability",
> ebc3226202d5956a5963185222982d435378b899 whereas irqfd support
> was brought in 84223598778ba08041f4297fda485df83414d57e,
> "KVM: s390: irq routing for adapter interrupts". Both commits
> first appear in 3.15 so there should not be any kernel
> version impacted by this QEMU modification.
Yes, I think we can live with disabling irqfd support for those
versions inbetween :)
>
> Signed-off-by: Eric Auger <address@hidden>
The patch looks sane to me and I verified that qemu works as expected
on s390 (current kernel, current kernel with KVM_CAP_IRQFD disabled
again and pre-KVM_CAP_IRQ_ROUTING). So:
Reviewed-by: Cornelia Huck <address@hidden>
Tested-by: Cornelia Huck <address@hidden>