[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 5/6] target-ppc: Clean up mullwo
From: |
Tom Musta |
Subject: |
[Qemu-ppc] [PATCH 5/6] target-ppc: Clean up mullwo |
Date: |
Mon, 25 Aug 2014 14:25:43 -0500 |
Simplify the implementation of mullwo. For 64 bit CPUs, the result is
the concatenation of the upper and lower parts of the muls2_i32 operation,
which may be slightly better than deposit. For 32 bit CPUs, the lower part
of the muls_i32 operation is moved into the target GPR.
Signed-off-by: Tom Musta <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
---
target-ppc/translate.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index ced295f..1062634 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -1150,19 +1150,14 @@ static void gen_mullwo(DisasContext *ctx)
{
TCGv_i32 t0 = tcg_temp_new_i32();
TCGv_i32 t1 = tcg_temp_new_i32();
-#if defined(TARGET_PPC64)
- TCGv_i64 t2 = tcg_temp_new_i64();
-#endif
tcg_gen_trunc_tl_i32(t0, cpu_gpr[rA(ctx->opcode)]);
tcg_gen_trunc_tl_i32(t1, cpu_gpr[rB(ctx->opcode)]);
tcg_gen_muls2_i32(t0, t1, t0, t1);
- tcg_gen_ext_i32_tl(cpu_gpr[rD(ctx->opcode)], t0);
#if defined(TARGET_PPC64)
- tcg_gen_ext_i32_tl(t2, t1);
- tcg_gen_deposit_i64(cpu_gpr[rD(ctx->opcode)],
- cpu_gpr[rD(ctx->opcode)], t2, 32, 32);
- tcg_temp_free(t2);
+ tcg_gen_concat_i32_i64(cpu_gpr[rD(ctx->opcode)], t0, t1);
+#else
+ tcg_gen_mov_i32(cpu_gpr[rD(ctx->opcode)], t0);
#endif
tcg_gen_sari_i32(t0, t0, 31);
--
1.7.1
- [Qemu-ppc] [PATCH 0/6] target-ppc: More Cleanup of FXU Instructions, Tom Musta, 2014/08/25
- [Qemu-ppc] [PATCH 2/6] target-ppc: Optimize rlwinm MB=0 ME=31, Tom Musta, 2014/08/25
- [Qemu-ppc] [PATCH 1/6] target-ppc: Special Case of rlwimi Should Use Deposit, Tom Musta, 2014/08/25
- [Qemu-ppc] [PATCH 3/6] target-ppc: Optimize rlwnm MB=0 ME=31, Tom Musta, 2014/08/25
- [Qemu-ppc] [PATCH 4/6] target-ppc: Clean Up mullw, Tom Musta, 2014/08/25
- [Qemu-ppc] [PATCH 5/6] target-ppc: Clean up mullwo,
Tom Musta <=
- [Qemu-ppc] [PATCH 6/6] target-ppc: Implement mulldo with TCG, Tom Musta, 2014/08/25
- Re: [Qemu-ppc] [PATCH 0/6] target-ppc: More Cleanup of FXU Instructions, Richard Henderson, 2014/08/25