[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call

From: Alexander Graf
Subject: Re: [Qemu-ppc] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call
Date: Mon, 30 Jun 2014 14:05:34 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 30.06.14 11:25, Nikunj A Dadhania wrote:
Alexander Graf <address@hidden> writes:

Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania <address@hidden>:

+static void rtas_ibm_os_term(PowerPCCPU *cpu,
+                            sPAPREnvironment *spapr,
+                            uint32_t token, uint32_t nargs,
+                            target_ulong args,
+                            uint32_t nret, target_ulong rets)
+    target_ulong ret = 0;
+    qapi_event_send_guest_panicked(GUEST_PANIC_ACTION_PAUSE, &error_abort);
The guest doesn't pause.
I see the event reaching libvirt and a dump taken and the guest

Since the guest will call os-term in a loop, this will also flood the
event listener with lots and lots of panic messages.
        do {
                status = rtas_call(rtas_token("ibm,os-term"), 1, 1, NULL,
        } while (rtas_busy_delay(status));

So when status from the rtas call is success, the loop should exit.

Am I missing something?

No, I think you're right. I'll queue it for 2.2.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]