[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] macio: Fix timer endianness

From: Mark Cave-Ayland
Subject: Re: [Qemu-ppc] [PATCH] macio: Fix timer endianness
Date: Thu, 05 Jun 2014 21:43:52 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0

On 27/05/14 01:01, Alexander Graf wrote:

The timer registers on our KeyLargo macio emulation are read as byte reversed
from the big endian guest, so we better expose them endian reversed as well.

This fixes initial hickups of booting Mac OS X with -M mac99 for me.

Signed-off-by: Alexander Graf <address@hidden>
  hw/misc/macio/macio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
index 7f99aa0..47f45f5 100644
--- a/hw/misc/macio/macio.c
+++ b/hw/misc/macio/macio.c
@@ -259,7 +259,7 @@ static uint64_t timer_read(void *opaque, hwaddr addr, 
unsigned size)
  static const MemoryRegionOps timer_ops = {
      .read = timer_read,
      .write = timer_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,

  static int macio_newworld_initfn(PCIDevice *d)

Amazing! This patch appears to fix booting my Darwin 8.01 test ISO with -M mac99 so it now gets to the installer - nice work!

Tested-by: Mark Cave-Ayland <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]