[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 1/4] cpus: Define callback for QEM
Re: [Qemu-ppc] [Qemu-devel] [PATCH v4 1/4] cpus: Define callback for QEMU "nmi" command
Thu, 5 Jun 2014 10:54:01 +0100
On 5 June 2014 00:36, Alexey Kardashevskiy <address@hidden> wrote:
> I'd rather remove return value at all, my mistake, I cannot see how NMI
> handler can possibly fail - noone can mask it after all :) If callback
> exists, I just call it and that's it. If it does not exist, it is
> "unsupported" and that's it. Would that be ok?
You're assuming the 'emergency prod the guest' mechanism
in all CPUs will always be a "can't possibly fail' one. You
need to either provide a failure code or have the documentation
specifically say this is a "best-effort" kind of command (the
latter would be fine I expect).