[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v4 05/29] target-ppc: Add "POWER" prefix to MMCRA

From: Alexey Kardashevskiy
Subject: Re: [Qemu-ppc] [PATCH v4 05/29] target-ppc: Add "POWER" prefix to MMCRA PMU registers
Date: Wed, 04 Jun 2014 11:36:43 +1000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06/04/2014 02:35 AM, Tom Musta wrote:
> On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
>> Since we started adding "POWER" prefix to 64bit PMU SPRs, let's finish
>> the transition and fix MMCRA and define a hypv version of it.
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> I'm still not a fan of "SPR_POWER_*" since these are now in the ISA (the 
> "_POWER_" seems redundant).

And I am still a fan of having specific name in a macro if there is chance
that SPR with the same name can have different numbers on different
platforms :)

Alex, judge please :)

> Aside from that ...
> Reviewed-by: Tom Musta <address@hidden>

Yup, thanks, putting it into my git tree to have them all in v5!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]