qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachi


From: Igor Mammedov
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState
Date: Fri, 16 May 2014 18:20:11 +0200

On Wed,  7 May 2014 17:42:57 +0300
Marcel Apfelbaum <address@hidden> wrote:

> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields
> are copied into MachineState. Removed duplicated fields from MachineState.
> 
> All the other changes are only mechanical refactoring, no semantic changes.
> 
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>    - I am perfectly aware that patches touching a lot of files
>      are not desirable, but this one is a very simple replacement
>      patch:
>        QEMUMachineInitArgs -> MachineState
>        args -> ms
>    - This is the simplest way to get rid of QEMUMachineInitArgs fast.
>
One more thing:
pc_q35_init() and pc_init1() both use qdev_get_machine() for adding
properties. Please replace it with passed in machine.

-- 
Regards,
  Igor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]