[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO access
Re: [Qemu-ppc] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO accesses on bigendian hosts
Tue, 8 Apr 2014 18:53:42 +0100
On 8 April 2014 18:24, Richard Henderson <address@hidden> wrote:
> On 04/08/2014 08:51 AM, Peter Maydell wrote:
>> The raven_io_read() and raven_io_write() functions pass and
>> return values in little-endian format (since the IO op struct
>> is marked DEVICE_LITTLE_ENDIAN); however they were storing the
>> values in the buffer to pass to address_space_read/write()
>> in host-endian order, which meant that on big-endian hosts
>> the values were inadvertently reversed. Use the *_le_p()
>> accessors instead so that we are consistent regardless of
>> host endianness.
> Reviewed-by: Richard Henderson <address@hidden>
Thanks; applied to master.