[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 2/4] spapr: Enable DABRX special register

From: Alexander Graf
Subject: Re: [Qemu-ppc] [PATCH 2/4] spapr: Enable DABRX special register
Date: Fri, 04 Apr 2014 14:21:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130910 Thunderbird/17.0.9

On 04/04/2014 08:13 AM, Alexey Kardashevskiy wrote:
On 04/04/2014 12:19 AM, Alexander Graf wrote:
On 03.04.14 15:14, Alexey Kardashevskiy wrote:
This advertises Data Address Breakpoint Register Extension (DABRX) to
the guest via hyperrtas list and enables it to migrate.
Do all CPUs we support (970 anyone) have DABRX support?
970MP and 970FX do. Support them too? Who cares? :)

Well, we do support running KVM on these and for KVM we default to -cpu host, so they're important to keep in mind.

Also who handles this hcall in the TCG case?
Good point...

What about older host kernels that don't
support xdabr yet?
They will ignore FW_FEATURE_XDABR, no?

How does a host kernel ignore anything here? We're telling the guest that we support an hcall without asking the host at all.

What about PR KVM?
Oh. Nothing. And we do not want to make this "hcall-xdabr" conditional,
right? Drop the whole patch? I am really confused now.

I think we should properly check whether we can handle this hcall and/or implement a handler for TCG and hosts which don't handle it themselves.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]