[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] softfloat: Introduce float32_to_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] softfloat: Introduce float32_to_uint64_round_to_zero |
Date: |
Mon, 31 Mar 2014 19:12:06 +0100 |
On 31 March 2014 19:07, Tom Musta <address@hidden> wrote:
> On 3/31/2014 12:48 PM, Peter Maydell wrote:
>> So, float64_to_uint64_round_to_zero() works by temporarily
>> fiddling with the rounding mode and then calling
>> float64_to_uint64(). Is there a reason for doing this
>> function like this rather than in the same way?
> True. But not all of the *_round_to_zero() routines do this, e.g.
> float32_to_int64_round_to_zero(). So no matter what I do, it is
> inconsistent with something.
>
> Do you prefer the fiddle-and-reuse approach? (I think I do, actually).
> If so, I will respin the patch.
I think that would be easier to review for correctness :-)
thanks
-- PMM
- [Qemu-ppc] [PATCH 0/9] target-ppc: VSX Bug Fixes, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 2/9] target-ppc: Bug: VSX Convert to Integer Should Truncate, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 3/9] target-ppc: Define Endian-Correct Accessors for VSR Field Acess, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 4/9] target-ppc: Correct LE Host Inversion of Lower VSRs, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 5/9] target-ppc: Correct Simple VSR LE Host Inversions, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 6/9] target-ppc: Correct VSX Scalar Compares, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 7/9] target-ppc: Correct VSX FP to FP Conversions, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 8/9] target-ppc: Correct VSX FP to Integer Conversion, Tom Musta, 2014/03/26
- [Qemu-ppc] [PATCH 9/9] target-ppc: Correct VSX Integer to FP Conversion, Tom Musta, 2014/03/26
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/9] target-ppc: VSX Bug Fixes, Anton Blanchard, 2014/03/27