[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/6] NUMA: check if the total numa me
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size |
Date: |
Wed, 26 Feb 2014 14:15:35 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 17, 2014 at 04:49:44PM +0100, Igor Mammedov wrote:
> From: Wanlong Gao <address@hidden>
>
> If the total number of the assigned numa nodes memory is not
> equal to the assigned ram size, it will write the wrong data
> to ACPI table, then the guest will ignore the wrong ACPI table
> and recognize all memory to one node. It's buggy, we should
> check it to ensure that we write the right data to ACPI table.
>
> Signed-off-by: Wanlong Gao <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> numa.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/numa.c b/numa.c
> index 7845036..d12a4f2 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -151,6 +151,16 @@ void set_numa_nodes(void)
> node_mem[i] = ram_size - usedmem;
> }
>
> + uint64_t numa_total = 0;
I was going to point out that variable declarations in the middle of
blocks goes against coding style (at least I was told so), but my patch
to amend CODING_STYLE to document it was ignored for 2 weeks, already.
So, I am not sure we really have that rule.
(Personally I am not against declaring variables in the middle of
blocks, I think it makes the code more readable, and it is perfectly
valid C99 code.)
Reviewed-by: Eduardo Habkost <address@hidden>
> + for (i = 0; i < nb_numa_nodes; i++) {
> + numa_total += node_mem[i];
> + }
> + if (numa_total != ram_size) {
> + fprintf(stderr, "qemu: numa nodes total memory size "
> + "should equal ram_size\n");
> + exit(1);
> + }
> +
> for (i = 0; i < nb_numa_nodes; i++) {
> if (!bitmap_empty(node_cpumask[i], MAX_CPUMASK_BITS)) {
> break;
> --
> 1.7.1
>
>
--
Eduardo
- [Qemu-ppc] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 1/6] vl.c: fix style issue, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 4/6] NUMA: Add numa_info structure to contain numa nodes info, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size, Igor Mammedov, 2014/02/17
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size,
Eduardo Habkost <=
- [Qemu-ppc] [PATCH 6/6] NUMA: expand MAX_NODES from 64 to 128, Igor Mammedov, 2014/02/17
- [Qemu-ppc] [PATCH 2/6] NUMA: move numa related code to new file numa.c, Igor Mammedov, 2014/02/17
- Re: [Qemu-ppc] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor, Michael S. Tsirkin, 2014/02/26