[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] PPC: sPAPR: Only use getpagesize() when we run wi
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH] PPC: sPAPR: Only use getpagesize() when we run with kvm |
Date: |
Fri, 21 Feb 2014 12:17:18 +0100 |
> Am 21.02.2014 um 11:56 schrieb Peter Maydell <address@hidden>:
>
>> On 21 February 2014 10:49, Alexander Graf <address@hidden> wrote:
>>
>>> On 21.02.2014, at 11:36, Peter Maydell <address@hidden> wrote:
>>>
>>>> On 21 February 2014 09:41, Alexander Graf <address@hidden> wrote:
>>>> This fixes a build breakage on win32 hosts.
>>>
>>> Unfortunately it doesn't:
>>>
>>> cam-vm-266:precise:qemu$ make -C build/w32
>>> make: Entering directory
>>> `/home/petmay01/linaro/qemu-from-laptop/qemu/build/w32'
>>> CC ppc64-softmmu/hw/ppc/spapr_pci.o
>>> cc1: warnings being treated as errors
>>> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c: In
>>> function ‘spapr_pci_msi_init’:
>>> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c:486:
>>> warning: implicit declaration of function ‘getpagesize’
>>> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c:486:
>>> warning: nested extern declaration of ‘getpagesize’
>>>
>>> The compiler complains that there's no declaration
>>> of the function you're trying to call before it gets
>>> around to deciding whether it can eliminate the code
>>> as unreachable.
>>
>> Meh. How about this?
>
> Yep, CONFIG_KVM is a sufficiently big hammer to fix this :-)
Awesome. Queued to ppc-next.
Alex
>
> thanks
> -- PMM