|
From: | Richard Henderson |
Subject: | Re: [Qemu-ppc] [Qemu-devel] [PATCH 05/18] target-ppc: Add ISA 2.06 divwe[u][o] Instructions |
Date: | Tue, 10 Dec 2013 10:30:49 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/10/2013 09:58 AM, Tom Musta wrote: >> > The second test can never be true, since ra has 32 zero bits. >> > Thus the first test is also pointless. > Hmm. Consider the case where GPR[RA] = 0xUUUUUUUU_80000000 (U=don't care) and > GPR[RB] = 0xUUUUUUUU_FFFFFFFF. Without these checks, I do not believe > overflow > will be properly detected. > Hmm. I'm not sure what I was thinking here. Ignore all that. r~
[Prev in Thread] | Current Thread | [Next in Thread] |