[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-para
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter |
Date: |
Tue, 19 Nov 2013 11:43:50 +0100 |
On 19.11.2013, at 11:36, Alexander Graf <address@hidden> wrote:
>
> On 19.11.2013, at 05:28, Alexey Kardashevskiy <address@hidden> wrote:
>
>> This adds very basic handlers for ibm,get-system-parameter and
>> ibm,set-system-parameter RTAS calls.
>>
>> The only parameter handled at the moment is
>> "platform-processor-diagnostics-run-mode" which is always disabled and
>> does not support changing. This is expected to make
>> "ppc64_cpu --run-mode=1" happy.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> Changes:
>> v3:
>> * reworked all return codes (in a separate patch)
>>
>> v2:
>> * addressed comments from Alex Graf
>> ---
>> hw/ppc/spapr_rtas.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>> include/hw/ppc/spapr.h | 2 ++
>> 2 files changed, 49 insertions(+)
>>
>> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
>> index f9897a5..d7b1f1d 100644
>> --- a/hw/ppc/spapr_rtas.c
>> +++ b/hw/ppc/spapr_rtas.c
>> @@ -224,6 +224,49 @@ static void rtas_stop_self(PowerPCCPU *cpu,
>> sPAPREnvironment *spapr,
>> env->msr = 0;
>> }
>>
>> +#define DIAGNOSTICS_RUN_MODE 42
>> +
>> +static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu,
>> + sPAPREnvironment *spapr,
>> + uint32_t token, uint32_t nargs,
>> + target_ulong args,
>> + uint32_t nret, target_ulong rets)
>> +{
>> + target_ulong papameter = rtas_ld(args, 0);
>
> Sorry, saw that one too late. What is a papameter? Is it related to the pope?
> :)
I changed it locally to "parameter" and applied the patch to ppc-next. Thanks a
lot.
Alex