|
From: | Tom Musta |
Subject: | Re: [Qemu-ppc] [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add Instructions |
Date: | Fri, 25 Oct 2013 08:49:48 -0500 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
On 10/24/2013 3:38 PM, Richard Henderson wrote:
On 10/24/2013 09:25 AM, Tom Musta wrote:\
<snip>
+ ft1 = tp##_to_##btp(s->fld[i], &env->fp_status); \ + ft0 = btp##_##sum(ft0, ft1, &env->fp_status); \ + xt.fld[i] = btp##_to_##tp(ft0, &env->fp_status); \
<snip>
You want to be using tp##muladd instead of widening to 128 bits.
Thanks for the suggestion, Richard. I will try it.
+ s = &xt; \ + } \ + else { \ + m = &xt; \Also be careful of the codingstyle.
To be fixed in V2 (checkpatch.pl missed this one).
[Prev in Thread] | Current Thread | [Next in Thread] |