Re: [Qemu-ppc] [Qemu-devel] [PATCH RFC qom-cpu 04/41] cpu: Introduce CPUClass::set_pc() for gdb_set_cpu_pc()

[Andreas Färber]

Richard or anyone,

Am 01.07.2013 19:09, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas Färber wrote:
>> This moves setting the Program Counter from gdbstub into target code.
>> Use uint64_t type as maximum replacement for target_ulong.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>>  gdbstub.c                   | 39 ++++++---------------------------------
>>  include/qom/cpu.h           |  1 +
>>  target-alpha/cpu.c          |  8 ++++++++
>>  target-arm/cpu.c            |  8 ++++++++
>>  target-cris/cpu.c           |  8 ++++++++
>>  target-i386/cpu.c           |  8 ++++++++
>>  target-lm32/cpu.c           |  8 ++++++++
>>  target-microblaze/cpu.c     |  8 ++++++++
>>  target-mips/cpu.c           | 14 ++++++++++++++
>>  target-openrisc/cpu.c       |  8 ++++++++
>>  target-ppc/translate_init.c |  8 ++++++++
>>  target-s390x/cpu.c          |  8 ++++++++
>>  target-sh4/cpu.c            |  8 ++++++++
>>  target-sparc/cpu.c          |  9 +++++++++
>>  target-xtensa/cpu.c         |  8 ++++++++
>>  15 files changed, 118 insertions(+), 33 deletions(-)
> 
> Reviewed-by: Richard Henderson <address@hidden>

This is the first case where I am proposing the use of uint64_t in place
of target_ulong. In this case a gdb command using such a hook is not
performance-sensitive. Do you see this as an acceptable path for adding
further CPUClass hooks such as MMU fault handling?

Should we introduce some ulong-target-max typedef similar to hwaddr or
use plain uint64_t as done here?

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg