Re: [Qemu-ppc] [v1][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size

[Scott Wood]

On 04/30/2013 06:31:41 PM, Chen, Tiejun wrote:
> > function that gets called later.  The comment doesn't make
>
> Are you saying I should replace cpu_to_be64(params->ram_size) with  
> cpu_to_be64(ram_size) directly in ppce500_load_device_tree()?

No, I'm saying to reword (or eliminate) the confusing comment.

> But as I understand we should sync this global argument after we  
> fixup something associated to that since params->ram_size may impact  
> on something else in the future.

...and we just hope that nothing uses it for anything important before  
the fixup. :-P

-Scott