Re: [Qemu-ppc] [Qemu-devel] [PATCH for-1.4 v3 3/6] error: Strip trailing '\n' from error string arguments (again)

[Markus Armbruster]

Alex Williamson <address@hidden> writes:

> On Fri, 2013-02-08 at 21:22 +0100, Markus Armbruster wrote:
>> Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
>> back.  Tracked down with this Coccinelle semantic patch:
>> 
>>     @r@
>>      expression err, eno, cls, fmt;
>>      position p;
>>     @@
>>     (
>>      error_report(fmt, ...)@p
>>     |
>>      error_set(err, cls, fmt, ...)@p
>>     |
>>      error_set_errno(err, eno, cls, fmt, ...)@p
>>     |
>>      error_setg(err, fmt, ...)@p
>>     |
>>      error_setg_errno(err, eno, fmt, ...)@p
>>     )
>>     @script:python@
>>      fmt << r.fmt;
>>      p << r.p;
>>     @@
>>     if "\\n" in str(fmt):
>>      print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  block/gluster.c             |   2 +-
>>  hmp.c                       |   2 +-
>>  hw/9pfs/virtio-9p-proxy.c   |   2 +-
>>  hw/pci/pci.c                |   2 +-
>>  hw/qdev.c                   |   4 +-
>>  hw/qxl.c                    |   2 +-
>>  hw/vfio_pci.c               | 110 
>> ++++++++++++++++++++++----------------------
>>  hw/vhost_net.c              |   4 +-
>>  migration.c                 |   2 +-
>>  qemu-char.c                 |   8 ++--
>>  target-i386/cpu.c           |  10 ++--
>>  target-ppc/translate_init.c |   2 +-
>>  ui/console.c                |   2 +-
>>  ui/input.c                  |   2 +-
>>  util/qemu-config.c          |   6 +--
>>  util/qemu-sockets.c         |   6 +--
>>  16 files changed, 83 insertions(+), 83 deletions(-)
>
> Maybe useful to cc maintainers of these files so they (me) can know to
> stop doing it.

Good point, better late than never: cc'ing folks named by
get_maintainer.pl with roles other than commit_signer and odd fixer.

>                 Is this something we can add to checkpatch?  Thanks,

I don't know.  String concatenation could make it a bit hairy.