[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host o
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR |
Date: |
Thu, 3 Jan 2013 13:26:38 +0100 |
On 18.12.2012, at 08:53, Andreas Färber wrote:
> Previously we silently exited, with subclasses we got an opcode warning.
> Instead explicitly tell the user what's wrong.
>
> An indication for this is -cpu ? showing "host" with an all-zero PVR.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> target-ppc/kvm.c | 7 +++++++
> 1 Datei geändert, 7 Zeilen hinzugefügt(+)
>
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index f115892..8998d0f 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -1186,7 +1186,14 @@ static void alter_insns(uint64_t *word, uint64_t
> flags, bool on)
>
> static void kvmppc_host_cpu_initfn(Object *obj)
> {
> + PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(obj);
> +
> assert(kvm_enabled());
> +
> + if (pcc->info->pvr != mfpvr()) {
> + fprintf(stderr, "Host PVR unsupported.\n");
This should probably rather say "Host CPU unsupported for -cpu host" or so :).
Not everyone who invokes qemu-system-ppc knows what a PVR is.
Alex
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-ppc] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR,
Alexander Graf <=