|
From: | Li Zhang |
Subject: | Re: [Qemu-ppc] commit 094b287 "Add USB option in machine options" broke i386 -usb |
Date: | Fri, 23 Nov 2012 00:50:38 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 |
On 2012年11月23日 00:49, Peter Maydell wrote:
On 22 November 2012 16:39, Peter Maydell <address@hidden> wrote:We use "-usb" to enable USB in this command line. That has to continue to work, for back compatibility. I think your code to try to support -usb is broken: case QEMU_OPTION_usb: machine_opts = qemu_opts_find(qemu_find_opts("machine"), 0); will return NULL if there are no user-set machine opts at this point, so we never go on to try to set the usb machine opt to true.Patch sent which fixes this bug.
Thanks for fixing that. :)
-- PMM
-- Li Zhang IBM China Linux Technology Centre
[Prev in Thread] | Current Thread | [Next in Thread] |