[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device lis
From: |
Avik Sil |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list |
Date: |
Fri, 12 Oct 2012 12:42:09 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/12/2012 04:29 AM, David Gibson wrote:
> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>> This patch adds nvram specified boot device into qemu default
>> boot_devices list. This helps firmware to boot from nvram specified
>> boot device if no -boot option is specified.
>
> I really don't think this is a good idea, it extends an already
> deprecated mechanism in a fuzzy way and requires careful checking to
> see if it could break anything. On all platforms the boot sequence
> should be:
> if bootindex is specified:
> boot according to bootindex
> else if -boot is specified:
> boot according to -boot sequence
> else:
> use platform firmware default sequence
>
> The last will of course vary by platform, and could depend on platform
> details like the contents of NVRAM. Your original idea of making it
> clear to the guest when -boot has been specified (as opposed to when
> it contains its default value) was the right one, and this "x" in
> -boot is going the wrong direction.
>
I'm fine with the original approach. The patch is there in qemu-ppc m-l [1].
Regards,
Avik
[1] http://lists.nongnu.org/archive/html/qemu-ppc/2012-10/msg00081.html
- [Qemu-ppc] [PATCH] Add nvram to default boot device list, Avik Sil, 2012/10/10
- Re: [Qemu-ppc] [PATCH] Add nvram to default boot device list, Alexander Graf, 2012/10/11
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list, David Gibson, 2012/10/11
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list, Avik Sil, 2012/10/15
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list, Alexander Graf, 2012/10/16
- Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list, Andreas Färber, 2012/10/16
Re: [Qemu-ppc] [Qemu-devel] [PATCH] Add nvram to default boot device list,
Avik Sil <=