[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 20/23] ppc: Suppress unused default drives
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [PATCH 20/23] ppc: Suppress unused default drives |
Date: |
Wed, 15 Aug 2012 14:40:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
Am 15.08.2012 14:30, schrieb Markus Armbruster:
> Alexander Graf <address@hidden> writes:
>
>> On 09.08.2012, at 16:54, Markus Armbruster <address@hidden> wrote:
>>
>>> Andreas Färber <address@hidden> writes:
>>>
>>>> Am 09.08.2012 15:31, schrieb Markus Armbruster:
>>>>> diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c
>>>>> index f2c6908..bcecc0a 100644
>>>>> --- a/hw/ppc_oldworld.c
>>>>> +++ b/hw/ppc_oldworld.c
>>>>> @@ -338,6 +338,8 @@ static QEMUMachine heathrow_machine = {
>>>>> .desc = "Heathrow based PowerMAC",
>>>>> .init = ppc_heathrow_init,
>>>>> .max_cpus = MAX_CPUS,
>>>>> + .no_floppy = 1,
>>>>> + .no_sdcard = 1,
>>>>> #ifndef TARGET_PPC64
>>>>> .is_default = 1,
>>>>> #endif
>>>>
>>>> Ack for SD.
>>>>
>>>> Not sure about the floppy. I thought the beige Old World machines used
>>>> to have a floppy with some incompatible Apple formatting... Did they use
>>>> a controller we don't implement? If so, then .no_floppy should get a
>>>> comment.
>>>
>>> I have no idea. Alex?
>>
>> I'd have to check wikipedia all the same :)
>
> All right, I did: they had some kind of floppy. No clue what kind.
>
> And we already have a comment:
>
> /* TOFIX: for now, the second IDE channel is not properly
> * used by OHW. The Mac floppy disk are not emulated.
> * For now, OHW cannot boot from the network.
> */
>
> Andreas, still want a comment next to .no_floppy?
Nah, no need then. :)
We should rather spend the time on getting OpenBIOS working with PReP...
o:-)
Andreas
Re: [Qemu-ppc] [PATCH 00/23] Suppress unused default drives, Peter Maydell, 2012/08/09