Re: [Qemu-ppc] [RFC/PATCH 1/1] USB code fenced for s390

[Andreas Färber]

Am 07.08.2012 14:19, schrieb Christian Borntraeger:
> From: Eugene Dvurechenski <address@hidden>
> 
> on s390 there is no usb support and the -usb option doesnt
> do anything.
> This patch fences all usb code for s390.
> 
> Signed-off-by: Eugene Dvurechenski <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
>  configure        |   66 +++++++++++++++++++++++++++++++++++++++++------------
>  hmp-commands.hx  |    6 +++++
>  hw/Makefile.objs |    5 ++-
>  monitor.c        |    4 +++
>  qemu-options.hx  |    4 +++
>  sysemu.h         |    2 +
>  vl.c             |    8 +++++-
>  7 files changed, 76 insertions(+), 19 deletions(-)

This patch seems to be mixing two things:

1) Disabling USB host support. If System z mainframes don't have USB
support, it doesn't make much sense to enable USB host passthrough.

2) Disabling USB support for guest machines. Wasn't there a recent
virtio-usb RFC? In that case it would very well be possible to connect
virtual USB devices (including smartcard) to the virtio s390 machine.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg