Re: [Qemu-ppc] [PATCH 4/4] Enable kvm emulated watchdog

[Alexander Graf]

On 01.08.2012, at 20:00, Scott Wood wrote:

> On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote:
>> 
>> 
>>> -----Original Message-----
>>> From: Alexander Graf [mailto:address@hidden
>>> Sent: Wednesday, August 01, 2012 7:57 AM
>>> To: Bhushan Bharat-R65777
>>> Cc: address@hidden List; address@hidden; Bhushan Bharat-R65777;
>>> qemu-devel qemu-devel; KVM list
>>> Subject: Re: [PATCH 4/4] Enable kvm emulated watchdog
>>> 
>>> 
>>> On 20.07.2012, at 07:23, Bharat Bhushan wrote:
>>>> @@ -384,6 +437,15 @@ int kvm_arch_init_vcpu(CPUPPCState *cenv)
>>>>        return ret;
>>>>    }
>>>> 
>>>> +    if (enable_watchdog_support) {
>>>> +        ret = kvm_watchdog_enable(cenv);
>>> 
>>> Do you think this is a good idea? Why would real hardware not implement a
>>> watchdog just because the user didn't select an action?
>> 
>> If there is no watchdog action then why we want to run watchdog timer?
> 
> On real hardware, if software sets WRC to a non-zero value, the watchdog
> action is a system reset.  The user doesn't have to do anything special.

So we eventually want a machine default that says "default watchdog action is 
system reset" that a user can then override. But we can do that in a later step.


Alex