Re: [Qemu-ppc] [PATCH] ppcmas_tlb_check: Fix effective address comparison

[Fabien Chouteau]

On 05/07/2012 06:43 PM, Alexander Graf wrote:
> 
> On 07.05.2012, at 18:41, Fabien Chouteau wrote:
> 
>> Use size mask in both operands of effective address comparison.
>> This is the expected as the size of EPN field in MAS2 depends on page
>> size.
>>
>> Definition of EPN field from e500v2 RM:
>> EPN Effective page number: Depending on page size, only the bits
>> associated with a page boundary are valid. Bits that represent offsets
>> within a page are ignored and should be cleared.
>>
>> There is a similar (but more complicated) definition in PowerISA V2.06.
> 
> Would it make sense to do this at tlbwe time? That path is a bit less hot 
> that the tlb check :).

Why not, I'll check that tomorrow.

Thanks,


-- 
Fabien Chouteau