[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500

From: Scott Wood
Subject: Re: [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode
Date: Thu, 12 Apr 2012 12:24:14 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 04/12/2012 11:59 AM, Andreas Färber wrote:
> Am 10.04.2012 22:04, schrieb Meador Inge:
>> commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache
>> line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block.
>> This is not correct because instructions like 'dcbz' need the dcache size
>> initialized even for user mode.
>> Signed-off-by: Meador Inge <address@hidden>
> Looks okay and compiles,
> Reviewed-by: Andreas Färber <address@hidden>
> Scott, are you planning to review this e500 patch? Or should I go ahead
> and apply?

I'm OK with it, though it may make more sense for USER_ONLY to just pick
an arbitrary cache line size (probably 32) than to try to imitate a
specific core.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]