[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 3/4] pseries: Consolidate hack for RTAS display-ch

From: Andreas Färber
Subject: Re: [Qemu-ppc] [PATCH 3/4] pseries: Consolidate hack for RTAS display-character usage
Date: Tue, 10 Apr 2012 19:17:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0

Am 04.04.2012 07:02, schrieb David Gibson:
> Currently the pseries machine contains not one but two somewhat ugly hacks
> to allow printing of early debug messages before the guest has properly
> read the device tree.
> First, we special case H_PUT_TERM_CHAR so that a vtermno of 0 (usually
> invalid) will look for a suitable vty and use that.  This supports Linux's
> early debug code which will use H_PUT_TERM_CHAR with vtermno==0 before
> reading the device tree.  Second, we support the RTAS display-character call. 
>  This takes no vtermno
> so we assume the address of the default first VTY.
> This patch makes things more consistent by folding the second hack into the
> first.  Now, display-character uses the existing vty_lookup() function to
> do the same search for a suitable VTY.
> Signed-off-by: David Gibson <address@hidden>
> ---
>  hw/spapr_rtas.c |    3 +--
>  hw/spapr_vio.h  |    1 +
>  hw/spapr_vty.c  |    4 +---
>  3 files changed, 3 insertions(+), 5 deletions(-)

Thanks, applied to ppc-next (rebreaking the overly long line in the
commit message):


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]