[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

From: Anthony Liguori
Subject: Re: [Qemu-ppc] [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30
Date: Tue, 01 Nov 2011 17:32:34 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 11/01/2011 05:28 PM, Alexander Graf wrote:

On 01.11.2011, at 15:16, Anthony Liguori<address@hidden>  wrote:

On 11/01/2011 05:14 PM, Alexander Graf wrote:
And specifically:

        QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) {
            PCIDevice *dev = (PCIDevice *)qdev;
            if (dev->devfn == devfn) {
                return dev;

QBus::children is a QTAILQ, not a QLIST.

Was this code tested at all?

Uh, yeah. Compile and execution tested O_o.

Do you not have libfdt installed?

I have libfdt installed on all boxes. I also verified that I could see a PCI 
device in the guest, so the code worked.

Maybe the list type was changed between the pullreq and now?

Yes.  The patch that did it was old but only recently got into the tree.


Anthony Liguori



Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]