[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppc: Alter CPU state to mask out TCG unimplemente
Re: [Qemu-ppc] [PATCH] ppc: Alter CPU state to mask out TCG unimplemented instructions as appropriate
Tue, 25 Oct 2011 15:57:31 +1100
On Tue, Oct 25, 2011 at 01:33:49PM +1100, David Gibson wrote:
> The CPU state contains two bitmaps, initialized from the CPU spec
> which describes which instructions are implemented on the CPU. A
> couple of bits are defined which cover instructions (VSX and DFP)
> which are not currently implemented in TCG. So far, these are only
> used to handle the case of -cpu host because a KVM guest can use
> the instructions when the host CPU supports them.
> However, it's a mild layering violation to simply not include those
> bits in the CPU descriptions for those CPUs that do support them,
> just because we can't handle them in TCG. This patch corrects the
> situation, so that the instruction bits _are_ shown correctly in the
> cpu spec table, but are masked out from the cpu state in the non-KVM
> Signed-off-by: David Gibson <address@hidden>
Sorry, disregard, there's a bug in it. Working on it now.
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!