qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code


From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code
Date: Tue, 4 Oct 2011 08:56:05 +0100

On 3 October 2011 21:43, Stefan Weil <address@hidden> wrote:
> The code is unused since 8 years, so remove it.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  linux-user/signal.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 89276eb..40c5eb1 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -1274,10 +1274,7 @@ setup_return(CPUState *env, struct target_sigaction 
> *ka,
>
>                if (__put_user(retcodes[idx], rc))
>                        return 1;
> -#if 0
> -               flush_icache_range((abi_ulong)rc,
> -                                  (abi_ulong)(rc + 1));
> -#endif
> +
>                retcode = rc_addr + thumb;
>        }

(since this is in the ARM section of this file)

Since this is writing guest code instructions, flushing the host icache
is clearly not the right thing. I'm just wondering how this ensures that
we don't have stale translated code for this address, though...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]