Re: [RFC PATCH-for-10.0 12/12] hw/s390x/zpci: Re-categorize as BRIDGE

[Thomas Huth]

On 25/03/2025 23.43, Philippe Mathieu-Daudé wrote:
> A 'zpci' device encapsulate a PCI device to be usable
> by System/Z. Categorize it as bridge.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/s390x/s390-pci-bus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 2591ee49c11..dbfe24f6eca 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -1562,7 +1562,7 @@ static void s390_pci_device_class_init(ObjectClass 
> *klass, void *data)
>       DeviceClass *dc = DEVICE_CLASS(klass);
>   
>       dc->desc = "zpci device";
> -    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);

It's not really a bridge (in the sense of a PCI bridge) ... I think it's 
maybe better to keep it in the MISC category to avoid confusion.

 Thomas