Re: [PATCH v6 04/10] ppc/pnv: Add a PSI bridge model for Power11

[Aditya Gupta]

On 25/03/25 20:08, Cédric Le Goater wrote:

> On 3/25/25 12:23, Aditya Gupta wrote:
> > Power11 core is same as Power10, reuse PNV10_PSI initialisation, by
> > declaring 'PNV11_PSI' as child class of 'PNV10_PSI'
> >
> > Cc: Cédric Le Goater <clg@kaod.org>
> > Cc: Frédéric Barrat <fbarrat@linux.ibm.com>
> > Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> > Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
> > Cc: Nicholas Piggin <npiggin@gmail.com>
> > Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
> I am removing this Rb.
Got it, I will take care in v7.
> > <...snip...>
> >
> > @@ -937,6 +937,29 @@ static const TypeInfo pnv_psi_power10_info = {
> >       .name          = TYPE_PNV10_PSI,
> >       .parent        = TYPE_PNV9_PSI,
> >       .class_init    = pnv_psi_power10_class_init,
> > +    .class_base_init = pnv_psi_power10_class_init,
>
> why change class_base_init ?

This was since I was keeping the P10 types as child of P11.

And for them to follow the same init, I found the .class_base_init to be 
a good option.


Based on your suggestion on Homer patch, I am thinking to drop these 
patches and just use p10 models.


Thanks,

- Aditya Gupta

> Thanks,
>
> C.