qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/10] fpu: Always decide snan_bit_is_one() at runtime


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 08/10] fpu: Always decide snan_bit_is_one() at runtime
Date: Mon, 17 Feb 2025 14:15:07 +0100
User-agent: Mozilla Thunderbird

On 17/2/25 13:50, Peter Maydell wrote:
Currently we have a compile-time shortcut where we return a hardcode
value from snan_bit_is_one() on everything except MIPS, because we
know that's the only target that needs to change
status->no_signaling_nans at runtime.

Remove the ifdef, so we always look at the status flag.  This means
we must update the two targets (HPPA and SH4) that were previously
hardcoded to return true so that they set the status flag correctly.

This has no behavioural change, but will be necessary if we want to
build softfloat once for all targets.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
  target/hppa/fpu_helper.c       | 1 +
  target/sh4/cpu.c               | 1 +
  fpu/softfloat-specialize.c.inc | 7 -------
  3 files changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]