[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 13/16] nbd/server: Support inactive nodes
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 13/16] nbd/server: Support inactive nodes |
Date: |
Wed, 5 Feb 2025 14:43:35 -0600 |
User-agent: |
NeoMutt/20250113 |
On Tue, Feb 04, 2025 at 10:14:04PM +0100, Kevin Wolf wrote:
> In order to support running an NBD export on inactive nodes, we must
> make sure to return errors for any operations that aren't allowed on
> inactive nodes. Reads are the only operation we know we need for
> inactive images, so to err on the side of caution, return errors for
> everything else, even if some operations could possibly be okay.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> nbd/server.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH v3 06/16] block: Fix crash on block_resize on inactive node, (continued)
- [PATCH v3 06/16] block: Fix crash on block_resize on inactive node, Kevin Wolf, 2025/02/04
- [PATCH v3 04/16] migration/block-active: Remove global active flag, Kevin Wolf, 2025/02/04
- [PATCH v3 05/16] block: Don't attach inactive child to active node, Kevin Wolf, 2025/02/04
- [PATCH v3 08/16] block: Add blockdev-set-active QMP command, Kevin Wolf, 2025/02/04
- [PATCH v3 09/16] block: Support inactive nodes in blk_insert_bs(), Kevin Wolf, 2025/02/04
- [PATCH v3 07/16] block: Add option to create inactive nodes, Kevin Wolf, 2025/02/04
- [PATCH v3 10/16] block/export: Don't ignore image activation error in blk_exp_add(), Kevin Wolf, 2025/02/04
- [PATCH v3 11/16] block: Drain nodes before inactivating them, Kevin Wolf, 2025/02/04
- [PATCH v3 13/16] nbd/server: Support inactive nodes, Kevin Wolf, 2025/02/04
- Re: [PATCH v3 13/16] nbd/server: Support inactive nodes,
Eric Blake <=
- [PATCH v3 12/16] block/export: Add option to allow export of inactive nodes, Kevin Wolf, 2025/02/04
- [PATCH v3 14/16] iotests: Add filter_qtest(), Kevin Wolf, 2025/02/04
- [PATCH v3 15/16] iotests: Add qsd-migrate case, Kevin Wolf, 2025/02/04
- [PATCH v3 16/16] iotests: Add (NBD-based) tests for inactive nodes, Kevin Wolf, 2025/02/04
- Re: [PATCH v3 00/16] block: Managing inactive nodes (QSD migration), Stefan Hajnoczi, 2025/02/05