[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 55/56] ui/sdl2: set swap interval explicitly when OpenGL is enable
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 55/56] ui/sdl2: set swap interval explicitly when OpenGL is enabled |
Date: |
Wed, 11 Sep 2024 14:14:20 +0200 |
From: Gert Wollny <gert.wollny@collabora.com>
Before 176e3783f2ab (ui/sdl2: OpenGL window context)
SDL_CreateRenderer was called unconditionally setting
the swap interval to 0. Since SDL_CreateRenderer is now no
longer called when OpenGL is enabled, the swap interval is
no longer set explicitly and vsync handling depends on
the environment settings which may lead to a performance
regression with virgl as reported in
https://gitlab.com/qemu-project/qemu/-/issues/2565
Restore the old vsync handling by explicitly calling
SDL_GL_SetSwapInterval if OpenGL is enabled.
Fixes: 176e3783f2ab (ui/sdl2: OpenGL window context)
Closes: https://gitlab.com/qemu-project/qemu/-/issues/2565
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID:
<01020191e05ce6df-84da6386-62c2-4ce8-840e-ad216ac253dd-000000@eu-west-1.amazonses.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
ui/sdl2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 574a22306d..51b7aa82ea 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -115,6 +115,7 @@ void sdl2_window_create(struct sdl2_console *scon)
SDL_SetHint(SDL_HINT_RENDER_BATCHING, "1");
scon->winctx = SDL_GL_CreateContext(scon->real_window);
+ SDL_GL_SetSwapInterval(0);
} else {
/* The SDL renderer is only used by sdl2-2D, when OpenGL is disabled */
scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0);
--
2.45.2
- [PULL 45/56] hw/input/adb-mouse: convert to use QemuInputHandler, (continued)
- [PULL 45/56] hw/input/adb-mouse: convert to use QemuInputHandler, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 46/56] hw/char: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 47/56] hw/core: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 48/56] hw/watchdog: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 49/56] hw/gpio: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 50/56] hw/misc: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 51/56] hw/pci-host: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 52/56] system: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- [PULL 53/56] ui/sdl2: release all modifiers, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 54/56] ui/sdl2: ignore GUI keys in SDL_TEXTINPUT handler, Philippe Mathieu-Daudé, 2024/09/11
- [PULL 55/56] ui/sdl2: set swap interval explicitly when OpenGL is enabled,
Philippe Mathieu-Daudé <=
- [PULL 56/56] ui: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/11
- Re: [PULL 00/56] Misc HW & UI patches, Philippe Mathieu-Daudé, 2024/09/12