Re: [PATCH v5 6/9] target/arm: Factor out code for setting MTE TCF0 field

[Philippe Mathieu-Daudé]

On 27/6/24 06:13, Gustavo Romero wrote:
> Factor out the code used for setting the MTE TCF0 field from the prctl
> code into a convenient function. Other subsystems, like gdbstub, need to
> set this field as well, so keep it as a separate function to avoid
> duplication and ensure consistency in how this field is set across the
> board.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   linux-user/aarch64/meson.build       |  2 ++
>   linux-user/aarch64/mte_user_helper.c | 34 ++++++++++++++++++++++++++++
>   linux-user/aarch64/mte_user_helper.h | 25 ++++++++++++++++++++
>   linux-user/aarch64/target_prctl.h    | 22 ++----------------
>   4 files changed, 63 insertions(+), 20 deletions(-)
>   create mode 100644 linux-user/aarch64/mte_user_helper.c
>   create mode 100644 linux-user/aarch64/mte_user_helper.h


> diff --git a/linux-user/aarch64/mte_user_helper.h 
> b/linux-user/aarch64/mte_user_helper.h
> new file mode 100644
> index 0000000000..ee3f6b190a
> --- /dev/null
> +++ b/linux-user/aarch64/mte_user_helper.h
> @@ -0,0 +1,25 @@
> +/*
> + * ARM MemTag convenience functions.
> + *
> + * This code is licensed under the GNU GPL v2 or later.
> + *
> + * SPDX-License-Identifier: LGPL-2.1-or-later
> + */
> +
> +#ifndef AARCH64_MTE_USER_HELPER_H
> +#define AARCH64_MTE USER_HELPER_H
> +
> +#include "qemu/osdep.h"

https://www.qemu.org/docs/master/devel/style.html#include-directives

  Do not include “qemu/osdep.h” from header files since the .c file
  will have already included it.

> +#include "qemu.h"

"qemu.h" shouldn't be required neither.

Conditional to removing both lines:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>