[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/28] migration/multifd: Avoid the final FLUSH in complete()
From: |
Fabiano Rosas |
Subject: |
[PULL 17/28] migration/multifd: Avoid the final FLUSH in complete() |
Date: |
Fri, 21 Jun 2024 14:54:23 -0300 |
From: Peter Xu <peterx@redhat.com>
We always do the flush when finishing one round of scan, and during
complete() phase we should scan one more round making sure no dirty page
existed. In that case we shouldn't need one explicit FLUSH at the end of
complete(), as when reaching there all pages should have been flushed.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Tested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/ram.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index ceea586b06..edec1a2d07 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3300,10 +3300,6 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
}
}
- if (migrate_multifd() && !migrate_multifd_flush_after_each_section() &&
- !migrate_mapped_ram()) {
- qemu_put_be64(f, RAM_SAVE_FLAG_MULTIFD_FLUSH);
- }
qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
return qemu_fflush(f);
}
--
2.35.3
- [PULL 07/28] monitor: Stop removing non-duplicated fds, (continued)
- [PULL 07/28] monitor: Stop removing non-duplicated fds, Fabiano Rosas, 2024/06/21
- [PULL 08/28] monitor: Simplify fdset and fd removal, Fabiano Rosas, 2024/06/21
- [PULL 09/28] monitor: Report errors from monitor_fdset_dup_fd_add, Fabiano Rosas, 2024/06/21
- [PULL 10/28] io: Stop using qemu_open_old in channel-file, Fabiano Rosas, 2024/06/21
- [PULL 11/28] migration: Add direct-io parameter, Fabiano Rosas, 2024/06/21
- [PULL 12/28] migration/multifd: Add direct-io support, Fabiano Rosas, 2024/06/21
- [PULL 13/28] tests/qtest/migration: Add tests for file migration with direct-io, Fabiano Rosas, 2024/06/21
- [PULL 14/28] monitor: fdset: Match against O_DIRECT, Fabiano Rosas, 2024/06/21
- [PULL 15/28] migration: Add documentation for fdset with multifd + file, Fabiano Rosas, 2024/06/21
- [PULL 16/28] tests/qtest/migration: Add a test for mapped-ram with passing of fds, Fabiano Rosas, 2024/06/21
- [PULL 17/28] migration/multifd: Avoid the final FLUSH in complete(),
Fabiano Rosas <=
- [PULL 18/28] migration: Rename thread debug names, Fabiano Rosas, 2024/06/21
- [PULL 19/28] migration: Use MigrationStatus instead of int, Fabiano Rosas, 2024/06/21
- [PULL 20/28] migration: Cleanup incoming migration setup state change, Fabiano Rosas, 2024/06/21
- [PULL 22/28] migration/docs: Update postcopy recover session for SETUP phase, Fabiano Rosas, 2024/06/21
- [PULL 21/28] migration/postcopy: Add postcopy-recover-setup phase, Fabiano Rosas, 2024/06/21
- [PULL 23/28] tests/migration-tests: Drop most WIN32 ifdefs for postcopy failure tests, Fabiano Rosas, 2024/06/21
- [PULL 24/28] tests/migration-tests: Always enable migration events, Fabiano Rosas, 2024/06/21
- [PULL 25/28] tests/migration-tests: migration_event_wait(), Fabiano Rosas, 2024/06/21
- [PULL 26/28] tests/migration-tests: Verify postcopy-recover-setup status, Fabiano Rosas, 2024/06/21
- [PULL 27/28] tests/migration-tests: Cover postcopy failure on reconnect, Fabiano Rosas, 2024/06/21